fix: edit button should be visible during started and stopped

fixes podman-desktop#7045 Signed-off-by: Florent Benoit <[email protected]>
feloy · May 2, 2024 · 10b8e7d · 10b8e7d
1 parent 7376bc8
commit 10b8e7d
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/packages/renderer/src/lib/ui/LoadingIconButton.spec.ts b/packages/renderer/src/lib/ui/LoadingIconButton.spec.ts
@@ -181,6 +181,43 @@ test.each([
     },
     expected: EXPECT_DISABLE,
   },
+  // edit action
+  {
+    name: 'edit action in started status should be enabled',
+    action: 'edit',
+    state: {
+      status: 'started',
+      inProgress: false,
+    },
+    expected: EXPECT_ENABLE,
+  },
+  {
+    name: 'edit action in unknown status should be disabled',
+    action: 'edit',
+    state: {
+      status: 'unknown',
+      inProgress: false,
+    },
+    expected: EXPECT_DISABLE,
+  },
+  {
+    name: 'edit action in starting status should be disabled',
+    action: 'edit',
+    state: {
+      status: 'starting',
+      inProgress: false,
+    },
+    expected: EXPECT_DISABLE,
+  },
+  {
+    name: 'edit action if in progress should be disabled',
+    action: 'edit',
+    state: {
+      status: 'started',
+      inProgress: true,
+    },
+    expected: EXPECT_DISABLE,
+  },
 ] as TestScenario[])('$name', ({ action, color, state, expected }) => {
   render(LoadingIconButton, {
     action: action,

diff --git a/packages/renderer/src/lib/ui/LoadingIconButton.svelte b/packages/renderer/src/lib/ui/LoadingIconButton.svelte
@@ -35,6 +35,9 @@ $: {
       case 'update':
         disable = state?.status === 'unknown';
         break;
+      case 'edit':
+        disable = state?.status !== 'started' && state?.status !== 'stopped';
+        break;
     }
   }
 }