Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Branch name doesn't conform to GIT standards" #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricCousineau-TRI
Copy link

@EricCousineau-TRI EricCousineau-TRI commented Oct 12, 2018

Resolves #74

Uses suggestion from @jan-hudec, using urllib, but keeping (at least some) backwards compatibility with existing source transforms.

Can supersede #7


This change is Reviewable

@EricCousineau-TRI
Copy link
Author

Difference from original error in #74:

$ git fetch upstream 
searching for changes
no changes found
From hg::ssh://[email protected]/osrf/sdformat
   501ada1..e50fb23  branches/pose_dom -> upstream/branches/pose_dom
 * [new tag]         sdformat3-mentor2_3.99.99%2Bmentor2v1.0 -> sdformat3-mentor2_3.99.99%2Bmentor2v1.0
 * [new tag]         sdformat4-mentor2_4.99.99%2Bmentor2v1.0 -> sdformat4-mentor2_4.99.99%2Bmentor2v1.0
 * [new tag]         sdformat4_4.0.0%7Epre1 -> sdformat4_4.0.0%7Epre1
 * [new tag]         sdformat4_4.0.0%7Epre2 -> sdformat4_4.0.0%7Epre2
 * [new tag]         sdformat4_4.0.0%7Epre3 -> sdformat4_4.0.0%7Epre3
 * [new tag]         sdformat4_4.3.0%7Epre1 -> sdformat4_4.3.0%7Epre1
 * [new tag]         sdformat4_4.3.0%7Epre2 -> sdformat4_4.3.0%7Epre2
 * [new tag]         sdformat5_5.0.0%7Ebeta1 -> sdformat5_5.0.0%7Ebeta1
 * [new tag]         sdformat5_5.0.0%7Ebeta2 -> sdformat5_5.0.0%7Ebeta2
 * [new tag]         sdformat6_6.0.0%7Epre1 -> sdformat6_6.0.0%7Epre1
 * [new tag]         sdformat8_8.0.0%7Epre1 -> sdformat8_8.0.0%7Epre1

@felipec
Copy link
Owner

felipec commented Jun 4, 2019

It is not clear exactly what the patch does, you need to write more description into the commit message.

Also, you should write a simple test case that reproduces the problem, so that we can add it to the test suite and make sure it's working correctly.

And you please rebase and send the pull request again?

@felipec felipec force-pushed the master branch 2 times, most recently from 62ccc3c to 6e13c1c Compare August 8, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Branch name doesn't conform to GIT standards"
2 participants