Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootupd_t permissive #2444

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

zpytela
Copy link
Contributor

@zpytela zpytela commented Nov 22, 2024

The updated package does not use a service unit nor a socket to be started by systemd.

The updated package does not use a service unit nor a socket one
to be started by systemd.

Related: coreos/bootupd#663
@dustymabe
Copy link
Contributor

dustymabe commented Nov 22, 2024

coreos/bootupd#663 is what dropped the use of systemd in the bootupd package.

@travier
Copy link
Contributor

travier commented Dec 4, 2024

I'm working on coreos/bootupd#790 and we will need either this PR or more rules.

@cgwalters
Copy link
Contributor

Yes just to reiterate I don't think SELinux confinement for bootupd itself is providing much value now. Back when it was socket activated, it made some sense because while we restricted to root access, we don't necessarily want all code that happens to run as uid 0 to be able to initiate bootloader changes.

But because there's no socket there's no "privilege changes" going on; bootupd is already pretty careful to only be touching things that it should be touching and so we're left only with "accidental damage" protection from the policy, but that same policy is just cramping development.

@dustymabe
Copy link
Contributor

Yes just to reiterate I don't think SELinux confinement for bootupd itself is providing much value now.

Yep. This should merge (I assume since @zpytela opened the PR). Just for history/context, we talked with @zpytela and the need (compliance) for policies for things only apply if they have systemd services.. even if they aren't daemons. Since coreos/bootupd#663 dropped the use of those then we should be able to drop the policy for it (unless we add back something similar in the future).

@HuijingHei
Copy link

Should we remove the bootupd module because bootupd is not a service anymore and we do not need the module?

@dustymabe
Copy link
Contributor

Should we remove the bootupd module because bootupd is not a service anymore and we do not need the module?

Yes. My understanding is that this PR was an initial step in that direction. @zpytela should we merge this and open a new PR for dropping the module completely?

@zpytela
Copy link
Contributor Author

zpytela commented Dec 11, 2024

As long as there is a service, there needs to be SELinux support for it.

@zpytela zpytela merged commit 20339d3 into fedora-selinux:rawhide Dec 11, 2024
4 checks passed
@zpytela zpytela deleted the bootpd-permissive branch December 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants