ci: Fix version number of packit generated srpms #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tags have a `v` prefix. Tell packit about it, so that it generates correct `Version:` numbers in the spec.
martinpitt
force-pushed
the
fix-packit-version
branch
from
3d669d0 to
2506606
Compare
martinpitt
changed the title
|
Failed as expected, I pushed the fix. |
|
Yay, green! @zpytela @bachradsusi can you please land this? That will unbreak the next "real" PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tags have a
vprefix. Tell packit about it, so that it generatescorrect
Version:numbers in the spec.Current TF installability tests currently fails on the "v38" vs. "38" version conflict as in #1843. As this is a separate issue from revdeps testing, and much more urgent, I'm sending a separate PR. I started with an empty commit which failed like this.