Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration option to ignore SSL errors #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add configuration option to ignore SSL errors #92

wants to merge 1 commit into from

Conversation

lkotek
Copy link
Contributor

@lkotek lkotek commented Oct 17, 2024 •
edited
Loading

Jenkins Pipeline Library relies on following plugin https://plugins.jenkins.io/http_request/ allowing us to set ignoreSslErrors to true, which may be useful at least for debugging purposes.

This PR exposes this option for functions provided by Jenkins Pipeline Library. The parameter is optional and its default value is false, that makes the original usage of the all affected functions intact.

@lkotek lkotek marked this pull request as ready for review October 17, 2024 13:52
@lkotek
Copy link
Contributor Author

lkotek commented Oct 17, 2024

Successfully tested using following functions:

submitTestingFarmRequest(payloadMap: requestPayload)
waitForTestingFarm(requestId: env.TESTING_FARM_JOB_ID, hook: hook)

submitTestingFarmRequest(payloadMap: requestPayload, suppressSslErrors: true)
waitForTestingFarm(requestId: env.TESTING_FARM_JOB_ID, hook: hook, suppressSslErrors: true)

@lkotek
Copy link
Contributor Author

lkotek commented Oct 23, 2024

Hi @msrb, may I ask about your opinion here? Is the change in the PR acceptable, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lkotek