Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for a 'minimal view' in addition to the reduced view … #913

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

njotto834
Copy link

…and extended view options.

@njotto834 njotto834 mentioned this pull request May 1, 2023
@federicoiosue federicoiosue self-requested a review May 3, 2023 06:00
@federicoiosue federicoiosue added this to the 6.3.0 milestone May 3, 2023
@federicoiosue
Copy link
Owner

federicoiosue commented May 3, 2023

Hi Nicholas,

great job!

Sorry for not having been completelly clear about any implementation's details into the issue #909 itself, I'll try to add more context here:

  • Before start working on any modification could be useful to start a conversation abut that change to avoid pitfalls or working on something different of what is meant to be implemented
  • Always give a look to the contributions guidelines (they're a little outdated, I'll give them a refresh as soon as possible, I promise) and be sure to test things if possible, show what the modifications apport to the app

In this specific case the requirement was to implement that view as alternative to the currently "reduced" one, avoiding adding another entry into the menu, here the description:

I'd really like to avoid overwhelming the main app's view with too many options, so this could eventually be an alternative to current Reduced view, to be choosed from inside settings. Exactly how that works right now color category colors

This because the future version 7.x will get a complete refresh of the UI, with card view, and no more than 3 view options should be available through menu into the notes list.

Another step further could be avoiding continue using "booleans and if/then" approach: if you want to try adding cleaner code you could try refactoring the whole thing in this sense (ex. creating an object that should represent the view mode and a factory to perform business logic on UI components depending on its state).

All of this just because when I started the app I didn't plannet to see it grow like this, so starting since a day I tried keeping code much cleaner for future management, and pull requests really have to do the same to help to continue like this.

@federicoiosue
Copy link
Owner

federicoiosue commented May 3, 2023

Here's a little undesired effect: when you create a note with no title an empty card will be show

Screenshot_20230503_082658

Screenshot_20230503_082637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants