Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update pondering message after max-analyze-time-minutes #896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Sep 1, 2021

"pondering on" message was not updated after max-analyze-time-minutes. thx > @hebaeba.

Though I also wrote the following dialog, it is not included in this PR because I am afraid that such warnings may be annoying. How do you think?

Paused by the time limit (XX min from yyyy-MM-dd HH:mm).

Push spacebar to resume.
Click "Settings > Engine" menu to change "Max Analyze Time".

(d9f755b in https://github.com/kaorahi/lizzie/tree/fix_max_time2)

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Sep 1, 2021
@kaorahi kaorahi mentioned this pull request Sep 1, 2021
@hope366
Copy link

hope366 commented Sep 3, 2021

I think it's a good change to display the d9f755b dialog message because it's easier to visually confirm that the analysis is complete.
Is it possible to display this dialog message in multiple languages?

@kaorahi
Copy link
Contributor Author

kaorahi commented Sep 6, 2021

See fdfa0af.

@hope366
Copy link

hope366 commented Sep 6, 2021

thank you very much.
As a Japanese version, I tried to create something like the following.
bunnseki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants