fix: Reduce feast-server container image size & fix dev image build #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchughesiv
force-pushed
the
container-cleanup
branch
from
6e901ae
to
ee1f858
Compare
tchughesiv
changed the title
tchughesiv
changed the title
tchughesiv
force-pushed
the
container-cleanup
branch
from
cefcbaf
to
5c77936
Compare
Signed-off-by: Tommy Hughes <[email protected]>
tchughesiv
force-pushed
the
container-cleanup
branch
from
5c77936
to
e16a378
Compare
dmartinol
reviewed
Nov 22, 2024
| COPY . . | ||
| RUN apt update && apt install -y -V ca-certificates lsb-release wget make git curl gcc && \ | ||
| curl -sL https://deb.nodesource.com/setup_20.x | bash - && \ | ||
| wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb && \ |
There was a problem hiding this comment.
one of these days we should investigate on the reason why these arrow source code bundle for debian is installed.
AFAIK, installing the pyarrow python package is the only thing we need to connect an arrow system.
I will track a GH issue to investigate and in case clear the dockerfile.
dmartinol
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve the Dockerfile to remove unnecessary packages and do some cleanup. This will reduce the current image size by over 300mb.
This is done by switching to the official python3 debian 11 slim image (
python:3.11-slim-bullseye) which handles some of cleanup around python installation. We also tell pip install not to use cache and remove thebuild-essentialpackage. Finally, we do some additional cleanup around apt.Additionally, this PR fixes
Dockerfile.devso that it builds local dev changes into a functional container image, as was its intent.Which issue(s) this PR fixes:
Fixes #4784