Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated python-helm-demo example to use MinIO instead of GS #4691

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dmartinol
Copy link
Contributor

What this PR does / why we need it:

Using MinIO instead of GCP storage to have an isolated, reproducible setup with no other external dependencies.

Which issue(s) this PR fixes:

Fixes #4690

@dmartinol dmartinol requested a review from a team as a code owner October 25, 2024 11:00
@dmartinol dmartinol changed the title Updated python-helm-demo example to use MinIO instead of GS fix: Updated python-helm-demo example to use MinIO instead of GS Oct 25, 2024

## First, let's set up a Redis cluster
1. Start minikube (`minikube start`)
2. Use helm to install a default Redis cluster
1. Use helm to install a default Redis cluster

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these numbers all 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown replaces them with the actual sequence:
https://www.markdownguide.org/basic-syntax/#ordered-lists

Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

dmartinol and others added 2 commits October 25, 2024 18:38
Co-authored-by: Francisco Arceo <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Redis example
3 participants