fix: Adapt project_id_exists validator for updated pydantic version #4680
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prathap P <[email protected]>
|
hey could fix the lint PR title issue? for the change, I think need to verify backward compatibility for lower pydantic versions 😄 |
Prathap-P
changed the title
|
Done |
Prathap-P
changed the title
Signed-off-by: Prathap P <[email protected]>
Prathap-P
force-pushed
the
v0.40-branch
branch
from
30c7647
to
c931e27
Compare
|
Hi @sudohainguyen |
Prathap-P
force-pushed
the
v0.40-branch
branch
from
2f5e0f4
to
d937de8
Compare
Signed-off-by: Prathap P <[email protected]>
Prathap-P
force-pushed
the
v0.40-branch
branch
from
d937de8
to
6003045
Compare
|
@sudohainguyen Can you approve other flows? |
sudohainguyen
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With pydantic version 2.9.2, values dict inside field validator will have all details like project_id, billing_project_id nested within data, this PR handles that and has one test case to validate.
Which issue(s) this PR fixes:
Fixes #4678