Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed proxy fix to use BrowserRouter basename #3541

Closed

Conversation

shumway743
Copy link

What this PR does / why we need it:
This PR simplifies the way the feast UI can run on a sub path, which is often needed when running behind a proxy. Instead of manually attaching an environment variable in front of each link/path, links are updated using the basename prop of BrowserRouter and exposes it as a prop on the FeastUI component. The primary benefit is maintainability (no need for links to be updated manually).

With this, a subpath can be specified by passing the basename prop, and by updating the projectListPromise on the FeastUI component in an index.js/index.tsx file.

An example running under the subpath "/feast" would look something like this:

<FeastUI basename="/feast" reactQueryClient={queryClient} feastUIConfigs={{ tabsRegistry: tabsRegistry, projectListPromise: fetch("/feast/projects-list.json", { headers: { "Content-Type": "application/json", }, }).then((res) => { return res.json(); }) }} />
Which issue(s) this PR fixes:

Fixes #

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shumway743
To complete the pull request process, please assign kevjumba after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevjumba in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stale
Copy link

stale bot commented Aug 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 10, 2023
@adchia adchia closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants