Skip to content

Commit

Permalink
renamed auth condition and types
Browse files Browse the repository at this point in the history
Signed-off-by: Daniele Martinoli <[email protected]>
  • Loading branch information
dmartinol committed Nov 26, 2024
1 parent cff7521 commit ae2eaf2
Show file tree
Hide file tree
Showing 19 changed files with 341 additions and 341 deletions.
18 changes: 9 additions & 9 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ const (
FailedPhase = "Failed"

// Feast condition types:
ClientReadyType = "Client"
OfflineStoreReadyType = "OfflineStore"
OnlineStoreReadyType = "OnlineStore"
RegistryReadyType = "Registry"
ReadyType = "FeatureStore"
KubernetesAuthReadyType = "KubernetesAuth"
ClientReadyType = "Client"
OfflineStoreReadyType = "OfflineStore"
OnlineStoreReadyType = "OnlineStore"
RegistryReadyType = "Registry"
ReadyType = "FeatureStore"
AuthorizationReadyType = "AuthorizationReadyType"

// Feast condition reasons:
ReadyReason = "Ready"
Expand Down Expand Up @@ -62,7 +62,7 @@ type FeatureStoreSpec struct {
// FeastProject is the Feast project id. This can be any alphanumeric string with underscores, but it cannot start with an underscore. Required.
FeastProject string `json:"feastProject"`
Services *FeatureStoreServices `json:"services,omitempty"`
AuthConfig *AuthConfig `json:"auth,omitempty"`
AuthzConfig *AuthzConfig `json:"authz,omitempty"`
}

// FeatureStoreServices defines the desired feast service deployments. ephemeral registry is deployed by default.
Expand Down Expand Up @@ -209,8 +209,8 @@ type OptionalConfigs struct {
Resources *corev1.ResourceRequirements `json:"resources,omitempty"`
}

// AuthConfig defines the authorization settings for the deployed Feast services.
type AuthConfig struct {
// AuthzConfig defines the authorization settings for the deployed Feast services.
type AuthzConfig struct {
KubernetesAuth *KubernetesAuth `json:"kubernetes,omitempty"`
}

Expand Down
14 changes: 7 additions & 7 deletions infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ spec:
spec:
description: FeatureStoreSpec defines the desired state of FeatureStore
properties:
auth:
description: AuthConfig defines the authorization settings for the
authz:
description: AuthzConfig defines the authorization settings for the
deployed Feast services.
properties:
kubernetes:
Expand Down Expand Up @@ -966,8 +966,8 @@ spec:
description: Shows the currently applied feast configuration, including
any pertinent defaults
properties:
auth:
description: AuthConfig defines the authorization settings for
authz:
description: AuthzConfig defines the authorization settings for
the deployed Feast services.
properties:
kubernetes:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
persistence:
file:
path: /data/registry.db
auth:
authz:
kubernetes:
roles:
- reader
Expand Down
8 changes: 4 additions & 4 deletions infra/feast-operator/dist/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ spec:
spec:
description: FeatureStoreSpec defines the desired state of FeatureStore
properties:
auth:
description: AuthConfig defines the authorization settings for the
authz:
description: AuthzConfig defines the authorization settings for the
deployed Feast services.
properties:
kubernetes:
Expand Down Expand Up @@ -974,8 +974,8 @@ spec:
description: Shows the currently applied feast configuration, including
any pertinent defaults
properties:
auth:
description: AuthConfig defines the authorization settings for
authz:
description: AuthzConfig defines the authorization settings for
the deployed Feast services.
properties:
kubernetes:
Expand Down
220 changes: 0 additions & 220 deletions infra/feast-operator/internal/controller/auth/auth.go

This file was deleted.

Loading

0 comments on commit ae2eaf2

Please sign in to comment.