Check for Empty values with is operator (#72)

fcurella · Jun 5, 2023 · 0084492 · 0084492
1 parent 5e3d335
commit 0084492
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/django_fakery/faker_factory.py b/django_fakery/faker_factory.py
@@ -146,7 +146,7 @@ def build_one(
 
             value = fields.get(field_name, Empty)
             if isinstance(model_field, models.ForeignKey):
-                if value == Empty:
+                if value is Empty:
                     value = fields.get(field_name + "_id", Empty)
 
                 if value == rels.SELECT:
@@ -156,15 +156,15 @@ def build_one(
 
                     value = fks_cache.get(cache_key, Empty)
 
-                    if value == Empty:
+                    if value is Empty:
                         try:
                             value = qs[0]
                         except IndexError:
                             value = evaluator.fake_value(model, model_field)
 
                         fks_cache[cache_key] = value
 
-                if not make_fks and ((value == Empty) or (value and value.pk is None)):
+                if not make_fks and ((value is Empty) or (value and value.pk is None)):
                     raise ForeignKeyError(
                         "Field {} is a required ForeignKey, but the related {}.{} model"
                         " doesn't have the necessary primary key.".format(
@@ -176,7 +176,7 @@ def build_one(
 
                 field_name += "_id"
 
-            if value != Empty:
+            if value is not Empty:
                 value = evaluator.evaluate(value)
             else:
                 if model_field.choices: