Do not send basket with seat with full discount to Sage X3 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/213-not-send-zero-transactions-to-sageX3
branch
from
afdf994 to
5d64e0b
Compare
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/213-not-send-zero-transactions-to-sageX3
branch
from
5d64e0b to
1e6d745
Compare
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/213-not-send-zero-transactions-to-sageX3
branch
from
1e6d745 to
94b2e73
Compare
igobranco
requested changes
Oct 2, 2024
Tiago-Salles
force-pushed
the
Tiago-Salles/issues/213-not-send-zero-transactions-to-sageX3
branch
from
94b2e73 to
8ef7f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a refactor to not send to
SageX3transactions that have 0 as total amount. That is, the transaction needs to be saved, but not generated from a receipt, as nothing was sold.