Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db transaction issue, retry pending #266

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

igobranco
Copy link
Member

@igobranco igobranco commented Mar 7, 2024

If some issue error occurs it should exist a
SageX3TransactionInformation object.
fixes #265
related to #261
Also fix django command that retry pending transactions. Refactor billing test


fix: bad exception handling

The next block is a bad practice:

except Exception as e:
  raise e

It doesn't do nothing.
fixes #264

If some issue error occurs it should exist a
`SageX3TransactionInformation` object.
fixes #265
related to #261
Also fix django command that retry pending transactions.
Refactor billing test
@igobranco igobranco self-assigned this Mar 7, 2024
The next block is a bad practice:
```python
except Exception as e:
  raise e
```
It doesn't do nothing.
fixes #264
@igobranco igobranco merged commit 681ccf2 into main Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed transaction integrations don't have an integration status Bad exception handling
1 participant