Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a Modal to inform the update of terms of service #9

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

dcoa
Copy link

@dcoa dcoa commented Oct 16, 2024

Description

This PR creates a new component ModalToS to force a user to accept the terms of service if a change on those has been implemented.

How to test

  • Install the component in the environment
  • Configure the settings via lms.setting.py
    MFE_CONFIG["MODAL_UPDATE_TERMS_OF_SERVICE"] = {
        "date_iso_8601": "2025-06-08",
        "title": {
            "en": "English modal title",
            "pt-pt": "Portuguese modal title"
        },
        "body": {
            "en": "English modal text",
            "pt-pt": "Portuguese modal text"
        },
        "data_authorization": True,
        "terms_of_service": True,
        "honor_code": True,
    }
 
  • Check the modal is being displayed and behave as expected.

image

@dcoa dcoa force-pushed the dcoa/nau-policy-modal branch from 9032730 to 13ea862 Compare October 16, 2024 12:43
@dcoa dcoa marked this pull request as ready for review October 16, 2024 12:59
@sandroscosta
Copy link

Hello @dcoa

I've been reviewing this PR and all looks great. I just have one question regarding the modal, mainly directed to Paragon

Is there a way for us to inject styling into labels? I don't know why there are defined as flexbox, but it creates a weird look when viewing the box on mobile. One solution would be to change the flex direction via a media query, but I guess that everything is tightly coupled with Paragon.

image

Can you give me some feedback on this? Thanks.

@dcoa dcoa force-pushed the dcoa/nau-policy-modal branch from dcc6c4f to a149a8d Compare November 3, 2024 23:15
@dcoa
Copy link
Author

dcoa commented Nov 3, 2024

Hi @sandroscosta , you were right that was a Paragon style issue, I fixed it, could you have a look?

image

@dcoa dcoa force-pushed the dcoa/nau-policy-modal branch from a149a8d to 13d1760 Compare November 3, 2024 23:37
@dcoa dcoa changed the title feat: create a Modal to inform the update uf terms of service feat: create a Modal to inform the update of terms of service Nov 5, 2024
Copy link

@sandroscosta sandroscosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done! LGTM!

@sandroscosta sandroscosta merged commit df89f7b into nau/redwood.master Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants