Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redwood): add nau learning footer customization #3

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

dcoa
Copy link

@dcoa dcoa commented Jul 1, 2024

This PR migrates the custom NAU footer changes to the Redwood version.

image

How to test

  1. Create a tutor redwood environment.
  2. Inside your environment clone the learning MFE and mount it with tutor mounts add ./frontend-app-learning.
  3. Inside the learning MFE, clone the footer repository with the current branch (remember to run npm install for both, the learning app and the footer).
  4. Create the module.config.js file and add the following configuration.
module.exports = {
  localModules: [
    { moduleName: '@edx/frontend-component-footer/dist', dir: './frontend-component-footer-nau', dist: 'src' },
    { moduleName: '@edx/frontend-component-footer', dir: './frontend-component-footer-nau', dist: 'src' },
  ],
};
  1. Run the command tutor images build learning-dev.
  2. Start your environment tutor dev start.
  3. Create a course and configure the organization info inside the LMS admin.
  4. Open the courseware and check you can see the changes.

sandroscosta and others added 3 commits July 1, 2024 21:48
Customize the MFE footer to have a similar appearance to Richie's footer.
Add a list of links that is easy to change
@dcoa dcoa force-pushed the dcoa/redwood-migration branch from dc764db to 7369b83 Compare July 1, 2024 22:59
@dcoa dcoa marked this pull request as ready for review July 1, 2024 23:08
@dcoa dcoa requested review from sandroscosta and igobranco July 1, 2024 23:40
@dcoa
Copy link
Author

dcoa commented Aug 12, 2024

Hi @sandroscosta have you been able to review this PR? Do you have any issues that should be addressed?

@sandroscosta
Copy link

@dcoa I'm pushing a refactor to help with footer configuration. I'll review everything after.

@sandroscosta sandroscosta force-pushed the dcoa/redwood-migration branch from 8605628 to 4865685 Compare August 23, 2024 16:56
* add new footer env vars to allow quick update of links
* remove incorrectly commited dist dir
@sandroscosta sandroscosta force-pushed the dcoa/redwood-migration branch from bb4d1c6 to f44c118 Compare August 23, 2024 20:01
Copy link

@sandroscosta sandroscosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and refactored. Everything looks good.

@dcoa
Copy link
Author

dcoa commented Aug 26, 2024

Thank you @sandroscosta, feel free to merge the PR at any time.

@sandroscosta sandroscosta merged commit 52e0153 into nau/redwood.master Aug 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants