Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:warn -> :warning #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanlchandler
Copy link

Newer versions of Elixir are aligned with Erlang log level names but to maintain backwards compatibility :warn is still being passed to the backend. However, the backend is calling Logger.compare_levels which in turn logs the warning below. This PR converts :warn to :warning before passing the levels to Logger.compare_levels and avoids littering your log files with these messages.

warning: the log level :warn is deprecated, use :warning instead
  (logger 1.16.3) lib/logger.ex:1168: Logger.elixir_level_to_erlang_level/1
  (logger 1.16.3) lib/logger.ex:627: Logger.compare_levels/2
  (airbrakex 0.1.9) lib/airbrakex/logger_backend.ex:63: Airbrakex.LoggerBackend.meet_level?/2
  (airbrakex 0.1.9) lib/airbrakex/logger_backend.ex:30: Airbrakex.LoggerBackend.handle_event/2
  (stdlib 5.2) gen_event.erl:814: :gen_event.server_update/4
  (stdlib 5.2) gen_event.erl:796: :gen_event.server_notify/4
  (stdlib 5.2) gen_event.erl:538: :gen_event.handle_msg/6
  (stdlib 5.2) proc_lib.erl:241: :proc_lib.init_p_do_apply/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant