failint: add ability to lint only tests #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
add_ability_to_only_lint_tests
branch
2 times, most recently
from
bb84131 to
3a3632a
Compare
Add the ability to lint only testing functions. This is useful to prevent hardcoded sleeps in tests leading to flaky tests. I have never worked with the AST package in Go so this requires extra carefulness. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_ability_to_only_lint_tests
branch
from
3a3632a to
20c90aa
Compare
krisleipus
approved these changes
May 29, 2023
Titasp
approved these changes
May 29, 2023
|
@fatih kind ping 🤗 |
|
@fatih ping |
|
@GiedriusS thank you. I opened a new PR that does it slightly different. You don't need to traverse the AST, hence it's better that way. Could you try it out? #43 |
|
Closing this in favor of #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to lint only testing functions. This is useful to prevent hardcoded sleeps in tests leading to flaky tests.
I have never worked with the AST package in Go so this requires extra carefulness.
Solves #30.