Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dataverse files without a persistentID #355

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Support Dataverse files without a persistentID #355

merged 6 commits into from
Feb 19, 2024

Commits on Mar 13, 2023

  1. Support Dataverse files without a persistentID 

    Add support for downloading Dataverse files that don't have a persistent
ID. Use the file ID instead.
    @santisoler
    santisoler committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    0321a08 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Don't assume that persistentId is always present 

    The `persistentId` key might be missing in the API response, while the
`ID` is always there. So, don't assume it exists when deciding which id
should be used to download the files.
    @santisoler
    santisoler committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    7ad5073 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Simplify the if statement 

    Both for a persistent_id as a None or as an empty string, we can
evaluate them with `if persistent_id:`.
    @santisoler
    santisoler committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1e670cf View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Merge branch 'main' into dataverse-without-persistentid

    @santisoler
    santisoler authored Apr 13, 2023
    Configuration menu
    Copy the full SHA
    23d2d02 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Merge branch 'main' into dataverse-without-persistentid

    @leouieda
    leouieda committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    93d9835 View commit details
    Browse the repository at this point in the history

  2. Only rely on the file ID, not PID

    @leouieda
    leouieda committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    15f7536 View commit details
    Browse the repository at this point in the history