Fixing/improving linkRegExp #453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves/improves the following: - Setting a custom linkRegExp messes with the logic for adding protocol or mailto. Use named capture groups in the regex, and add a case in the href generation that just uses the match directly if neither the url nor the email regex matches, which would mean that the user's custom regex matched instead. - Make https the default protocol instead of http - Use a more general regex for matching the protocol. Signed-off-by: Øyvind Rønningstad <[email protected]>
A map of capture groups to functions for producing the href of a link. By default, it is e.g. used to prepend https:// to links matching on www. so they are not interpreted as relative. The user can add their own handlers if modifying linkRegExp. Signed-off-by: Øyvind Rønningstad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkRegExp seemed to not quite work as intended if modified by the user. This attempts to fix some issues with custom linkRegExp, and add some nice to have features. Take what you want, cheers.