Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RF to config templates for "Merge" layers #1121

Merged

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Nov 11, 2024

Description

Recent changes to nnet_merge_stream.h make it rely on RF, which is not set in the config template. This adds the missing functionality. I've added it across all backends, even though some don't rely on the feature (yet). Closes #1088

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

This would show up if we synthesized the projects from test_merge (that use vivado + io_stream)

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar mentioned this pull request Nov 11, 2024
4 tasks
@JanFSchulte JanFSchulte merged commit b44426d into fastmachinelearning:main Nov 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge_template reuse_factor
2 participants