Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Signer Removal Validation #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve Signer Removal Validation #411

wants to merge 1 commit into from

Commits on Feb 16, 2024

  1. Improve Signer Removal Validation 

    This update enhances the security and robustness of the removeSigner function in our smart contract. Previously, the function allowed for the removal of any address as a signer, without checking if the address was indeed a signer. This could lead to unnecessary state changes and events being emitted for non-signer addresses, potentially causing confusion.

To address this, we've introduced a requirement check to ensure that an address is an existing signer before it can be removed. This change prevents state modifications and event emissions for addresses that are not signers, thus tightening the contract's logic and ensuring actions reflect actual state changes.

Key Benefits:

Enhanced Security: By verifying that an address is a current signer before removal, we prevent unnecessary or accidental modifications to the signer list.
Improved Clarity: The contract's logic is now more straightforward, with actions closely reflecting the actual state of signers.
Reduced Confusion: Emitting events only for actual state changes makes the contract's behavior more predictable and easier to follow.
This minor yet impactful enhancement aligns with best practices in smart contract development, contributing to the overall security and maintainability of our protocol.
    Lawyered committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    cc8d206 View commit details
    Browse the repository at this point in the history