Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close event registration before event date. #32

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

thekingslee
Copy link
Contributor

Description

  • Close event before event date
  • Support external registration via links

Fixes # (issue)

Two new fields were introduced to the table.

  • registration_link
  • registration_closed

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for faraday-event ready!

Name Link
🔨 Latest commit cc1ec39
🔍 Latest deploy log https://app.netlify.com/sites/faraday-event/deploys/65bae22bda8d150008534844
😎 Deploy Preview https://deploy-preview-32--faraday-event.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for brave-jennings-3d7606 ready!

Name Link
🔨 Latest commit cc1ec39
🔍 Latest deploy log https://app.netlify.com/sites/brave-jennings-3d7606/deploys/65bae22b9f3fa300080643df
😎 Deploy Preview https://deploy-preview-32--brave-jennings-3d7606.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thekingslee
Copy link
Contributor Author

@jomefavourite @devgenix any idea why the deployment is failing?

@jomefavourite
Copy link
Member

@jomefavourite @devgenix any idea why the deployment is failing?

Maybe check Netlify why it fails

@devgenix
Copy link
Contributor

@nworiekingslee @jomefavourite

This is the build logs;

2:26:22 PM: build-image version: fcb0c1b3ada6d25c1cb58e8bc514f5f23cc14f15 (focal)
2:26:22 PM: buildbot version: cebdba79ad7a05d907da43c2d1e258ff94a7afe0
2:26:22 PM: Fetching cached dependencies
2:26:22 PM: Failed to fetch cache, continuing with build
2:26:22 PM: Starting to prepare the repo for build
2:26:22 PM: No cached dependencies found. Cloning fresh repo
2:26:22 PM: git clone --filter=blob:none https://github.com/faradayafrica/Faraday-event
2:26:22 PM: Preparing Git Reference pull/32/head
2:26:24 PM: Starting to install dependencies
2:26:24 PM: Python version set to 3.8
2:26:24 PM: Attempting Ruby version 2.7.2, read from environment
2:26:25 PM: Using Ruby version 2.7.2
2:26:25 PM: Started restoring cached go cache
2:26:25 PM: Finished restoring cached go cache
2:26:25 PM: Installing Go version 1.16.5 (requested 1.16.5)
2:26:29 PM: go version go1.16.5 linux/amd64
2:26:29 PM: Using PHP version 8.0
2:26:30 PM: Downloading and installing node v16.20.2...
2:26:30 PM: Downloading https://nodejs.org/dist/v16.20.2/node-v16.20.2-linux-x64.tar.xz...
2:26:31 PM: Computing checksum with sha256sum
2:26:31 PM: Checksums matched!
2:26:33 PM: Now using node v16.20.2 (npm v8.19.4)
2:26:33 PM: Enabling Node.js Corepack
2:26:33 PM: Started restoring cached build plugins
2:26:33 PM: Finished restoring cached build plugins
2:26:33 PM: Started restoring cached corepack dependencies
2:26:33 PM: Finished restoring cached corepack dependencies
2:26:33 PM: No npm workspaces detected
2:26:33 PM: Started restoring cached node modules
2:26:33 PM: Finished restoring cached node modules
2:26:33 PM: Installing npm packages using npm version 8.19.4
2:26:34 PM: npm ERR! code ERESOLVE
2:26:34 PM: npm ERR! ERESOLVE could not resolve
2:26:34 PM: npm ERR!
2:26:34 PM: npm ERR! While resolving: [email protected]
2:26:34 PM: npm ERR! Found: [email protected]
2:26:34 PM: npm ERR! node_modules/react
2:26:34 PM: npm ERR! react@"^17.0.2" from the root project
2:26:34 PM: npm ERR! peer react@"*" from @testing-library/[email protected]
2:26:34 PM: npm ERR! node_modules/@testing-library/react
2:26:34 PM: npm ERR! @testing-library/react@"^12.1.2" from the root project
2:26:34 PM: npm ERR! 9 more (react-countdown, react-dom, react-helmet, ...)
2:26:34 PM: npm ERR!
2:26:34 PM: npm ERR! Could not resolve dependency:
2:26:34 PM: npm ERR! peer react@"^16.6.0" from [email protected]
2:26:34 PM: npm ERR! node_modules/react-meta-tags
2:26:34 PM: npm ERR! react-meta-tags@"^1.0.1" from the root project
2:26:34 PM: npm ERR!
2:26:34 PM: npm ERR! Conflicting peer dependency: [email protected]
2:26:34 PM: npm ERR! node_modules/react
2:26:34 PM: npm ERR! peer react@"^16.6.0" from [email protected]
2:26:34 PM: npm ERR! node_modules/react-meta-tags
2:26:34 PM: npm ERR! react-meta-tags@"^1.0.1" from the root project
2:26:34 PM: npm ERR!
2:26:34 PM: npm ERR! Fix the upstream dependency conflict, or retry
2:26:34 PM: npm ERR! this command with --force, or --legacy-peer-deps
2:26:34 PM: npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
2:26:34 PM: npm ERR!
2:26:34 PM: npm ERR! See /opt/buildhome/.npm/eresolve-report.txt for a full report.
2:26:34 PM: npm ERR! A complete log of this run can be found in:
2:26:34 PM: npm ERR! /opt/buildhome/.npm/_logs/2024-01-31T13_26_33_912Z-debug-0.log
2:26:34 PM: Error during npm install
2:26:35 PM: Failed during stage "Install dependencies": dependency_installation script returned non-zero exit code: 1
2:26:35 PM: Failing build: Failed to install dependencies
2:26:35 PM: Finished processing build request in 13.106s

@jomefavourite
Copy link
Member

@nworiekingslee maybe change the install script on netlify to this

npm install -f

@devgenix devgenix merged commit 44826d3 into main Feb 1, 2024
9 of 10 checks passed
@devgenix
Copy link
Contributor

devgenix commented Feb 1, 2024

@nworiekingslee This doesn't look good
image

@Bluebberies
Copy link
Contributor

@devgenix can I be assigned to work on that?

@devgenix
Copy link
Contributor

devgenix commented Feb 1, 2024

@devgenix can I be assigned to work on that?

Yes please.

Instead of the current look, instead contain the link in a button that opens in another tab when clicked.

The button color should be the brand green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants