Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-7 setup subfolder structure. #8

Merged
merged 1 commit into from
May 3, 2024
Merged

Issue-7 setup subfolder structure. #8

merged 1 commit into from
May 3, 2024

Conversation

codecodeio
Copy link
Contributor

@codecodeio codecodeio commented May 2, 2024 •
edited
Loading

@codecodeio codecodeio linked an issue May 2, 2024 that may be closed by this pull request
Setup Subfolder Structure #7
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 2, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 2, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

bdeffleyfamous
bdeffleyfamous approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site still loads with files moved into sub folder. All references appear to be updated correctly.

tonyklapatch
tonyklapatch approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Homepage, JS, and CSS still loads correctly.

@tonyklapatch tonyklapatch merged commit 12cd8e3 into main May 3, 2024
2 checks passed
@codecodeio codecodeio deleted the 7-setup-subfolder-structure branch June 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

@tonyklapatch tonyklapatch tonyklapatch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Subfolder Structure
3 participants
@codecodeio @tonyklapatch @bdeffleyfamous