Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hreflang link attribute to head #68

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add hreflang link attribute to head #68

merged 2 commits into from
Jun 20, 2024

Conversation

tonyklapatch
Copy link
Contributor

hreflang link attribute should be added to every page, only for English.

Fix #67

Test URLs:

@tonyklapatch tonyklapatch linked an issue Jun 19, 2024 that may be closed by this pull request
Add hreflang meta attribute #67
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 19, 2024 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

bdeffleyfamous
bdeffleyfamous approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. hreflang is in the head on all pages.

codecodeio
codecodeio approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function commented. The function remains in scripts.js so it is near the document.documentElement.lang assignment.

@codecodeio codecodeio merged commit 041b4a8 into main Jun 20, 2024
2 checks passed
@codecodeio codecodeio deleted the 67-hreflang branch June 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

@codecodeio codecodeio codecodeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hreflang meta attribute
3 participants
@tonyklapatch @codecodeio @bdeffleyfamous