Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image formatting in one function. Meta/jsonld image paths corrected #66

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Image formatting in one function. Meta/jsonld image paths corrected #66

merged 2 commits into from
Jun 19, 2024

Conversation

codecodeio
Copy link
Contributor

@codecodeio codecodeio linked an issue Jun 19, 2024 that may be closed by this pull request
Homepage image paths #63
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 19, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

tonyklapatch
tonyklapatch approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, open graph and twitter tag image URLs in the head load their correct URLs on the homepage, article list, and article pages.

bdeffleyfamous
bdeffleyfamous approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct image paths appear everywhere.

@bdeffleyfamous bdeffleyfamous merged commit 4097f09 into main Jun 19, 2024
2 checks passed
@bdeffleyfamous bdeffleyfamous deleted the 63-homepage-image-paths branch June 19, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

@tonyklapatch tonyklapatch tonyklapatch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homepage image paths
3 participants
@codecodeio @tonyklapatch @bdeffleyfamous