Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for /best-cigars-guide in path. #62

Merged
merged 3 commits into from
Jun 18, 2024
Merged

check for /best-cigars-guide in path. #62

merged 3 commits into from
Jun 18, 2024

Conversation

codecodeio
Copy link
Contributor

@codecodeio codecodeio linked an issue Jun 18, 2024 that may be closed by this pull request
Homepage Missing Images #61
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 18, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 18, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

bdeffleyfamous
bdeffleyfamous approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work. It does not break the current images.

tonyklapatch
tonyklapatch approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images still load correctly on development. Using Chrome local overrides, I was able to verify the images also loaded on production correctly with these changes.

image

@tonyklapatch tonyklapatch merged commit f9b748b into main Jun 18, 2024
2 checks passed
@tonyklapatch tonyklapatch deleted the 61-homepage-missing-images branch June 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

@tonyklapatch tonyklapatch tonyklapatch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homepage Missing Images
3 participants
@codecodeio @tonyklapatch @bdeffleyfamous