Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use index title for category dropdown #51

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

bdeffleyfamous
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #50

Category drop down should be using the title from category-index.json.
Specifically, the dropdown text value for /best-cigars-by-shape-type-size should be 'Best Cigars By Shape, Type & Size'
H1 and meta title should match on category pages.

Test URLs:

@bdeffleyfamous bdeffleyfamous linked an issue Jun 11, 2024 that may be closed by this pull request
Copy link

aem-code-sync bot commented Jun 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jun 11, 2024

Page Scores Audits Google
/best-cigars-guide/best-cigars-by-country PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'm seeing the , and & in the dropdown when Best Cigars by Shape, Type & Size is selected.

Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The category dropdown still functions for all categories.

@codecodeio codecodeio merged commit 4226fbe into main Jun 12, 2024
2 checks passed
@codecodeio codecodeio deleted the 50-category-dropdown branch June 12, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category Dropdown should use index title.
3 participants