Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add half star ratings to the articles import #44

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

tonyklapatch
Copy link
Contributor

Fixes half stars for item ratings not being imported in the articles import. All articles have been re-imported into Sharepoint.

Sample page with an item with a half star rating: /best-cigars-guide/best-cigars-by-country/top-10-dominican-cigars - La Aurora Preferidos Gold Dominican Corojo should have 4.5 stars:

image

Fix #43

Test URLs:

@tonyklapatch tonyklapatch linked an issue Jun 6, 2024 that may be closed by this pull request
Copy link

aem-code-sync bot commented Jun 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jun 6, 2024

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@tonyklapatch
Copy link
Contributor Author

Not sure whats going on with the PSI check, manually running it is successful:

image

Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the half stars are imported into Sharepoint article docs and appear on the site.

@codecodeio codecodeio merged commit 778e811 into main Jun 7, 2024
2 checks passed
@codecodeio codecodeio deleted the 43-half-star-fix branch June 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Half Star Rating On Article Import
3 participants