Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 add category list #42

Merged
merged 5 commits into from
Jun 6, 2024
Merged

41 add category list #42

merged 5 commits into from
Jun 6, 2024

Conversation

bdeffleyfamous
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous commented Jun 6, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #41

Test URLs:

On article pages, all articles from the same category should be listed in the side bar (except the article itself).

@bdeffleyfamous bdeffleyfamous linked an issue Jun 6, 2024 that may be closed by this pull request
Copy link

aem-code-sync bot commented Jun 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jun 6, 2024

Page Scores Audits Google
/top-10-dominican-cigars PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 41-add-category-list June 6, 2024 17:23 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 41-add-category-list June 6, 2024 17:27 Inactive
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing all of Tony's changes from the Article styling ticket because of the way this was merged but I reviewed your first commit. Everything looks good. In the future we may want to create separate indexes for each category so we don't have to parse all articles to create the category article list.

Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I'm seeing the links in the sidebar. The current page does not display as a link.

@tonyklapatch tonyklapatch merged commit 46053ee into main Jun 6, 2024
2 checks passed
@tonyklapatch tonyklapatch deleted the 41-add-category-list branch June 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Category List to Articles Pages
3 participants