Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17 add search and indexing #19

Merged
merged 11 commits into from
May 15, 2024
Merged

17 add search and indexing #19

merged 11 commits into from
May 15, 2024

Conversation

bdeffleyfamous
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous commented May 9, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Added /best-cigars-guide/search.docx as search results page
Updated search query param from 's' to 'q'

Set up custom indexing. New pages are indexed as they are published in /best-cigars/guide/index/query-index.xlsx and category-index.xlsx

The custom index was added to handle the different structure of category list pages.

You should be able to use the search bar in the header and find available posts. For example search for 'best'.

Fix #17

Test URLs:

@bdeffleyfamous bdeffleyfamous linked an issue May 9, 2024 that may be closed by this pull request
Copy link

aem-code-sync bot commented May 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 9, 2024

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 17-add-search-and-indexing May 9, 2024 19:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 17-add-search-and-indexing May 9, 2024 20:07 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 17-add-search-and-indexing May 9, 2024 20:12 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 17-add-search-and-indexing May 9, 2024 20:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 17-add-search-and-indexing May 14, 2024 12:50 Inactive
@codecodeio
Copy link
Contributor

I was able to complete a search and get results.

I was able to add to the index by previewing a file on the branch for this ticket.

https://17-add-search-and-indexing--best-cigars-guide--famous-smoke.hlx.page/query-index.json

The js/css comes from an aem block template and will be customized and styled on another ticket

aem-block-collection/blocks/search at main · adobe/aem-block-collection

Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I was able to get a few results searching for "cigar".

@tonyklapatch tonyklapatch merged commit b2179e6 into main May 15, 2024
2 checks passed
@codecodeio codecodeio deleted the 17-add-search-and-indexing branch June 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search and indexing
3 participants