-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17 add search and indexing #19
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
I was able to complete a search and get results. I was able to add to the index by previewing a file on the branch for this ticket. https://17-add-search-and-indexing--best-cigars-guide--famous-smoke.hlx.page/query-index.json The js/css comes from an aem block template and will be customized and styled on another ticket aem-block-collection/blocks/search at main · adobe/aem-block-collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I was able to complete a search and get results.
-
I was able to add to the index by previewing a file on the branch for this ticket.
-
The js/css comes from an aem block template and will be customized and styled on another ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I was able to get a few results searching for "cigar".
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Added /best-cigars-guide/search.docx as search results page
Updated search query param from 's' to 'q'
Set up custom indexing. New pages are indexed as they are published in /best-cigars/guide/index/query-index.xlsx and category-index.xlsx
The custom index was added to handle the different structure of category list pages.
You should be able to use the search bar in the header and find available posts. For example search for 'best'.
Fix #17
Test URLs: