Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13 implement custom 404 page #16

Merged
merged 2 commits into from
May 14, 2024
Merged

13 implement custom 404 page #16

merged 2 commits into from
May 14, 2024

Conversation

bdeffleyfamous
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous commented May 8, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Tough one to get the tests to pass. Since this is the 404 page, the test aem-psi-check fails because the response is 404.
Just load the After and add /somegibberish at the end.

404 page should resemble the one currently www.famous-smoke.com/best-cigars-guide

Fix #13

Test URLs:

@bdeffleyfamous bdeffleyfamous linked an issue May 8, 2024 that may be closed by this pull request
Implement custom 404 page #13
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 8, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

codecodeio
codecodeio approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We will work on styling the page text and links to match the original on another ticket.

tonyklapatch
tonyklapatch approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404 page is displaying correctly, link goes back to homepage.

@tonyklapatch tonyklapatch merged commit 0481d2e into main May 14, 2024
2 checks passed
@tonyklapatch tonyklapatch deleted the 13-implement-custom-404-page branch May 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyklapatch tonyklapatch tonyklapatch approved these changes

@codecodeio codecodeio codecodeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement custom 404 page
3 participants
@bdeffleyfamous @codecodeio @tonyklapatch