Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10 create the footer block #15

Merged
merged 3 commits into from
May 10, 2024
Merged

10 create the footer block #15

merged 3 commits into from
May 10, 2024

Conversation

tonyklapatch
Copy link
Contributor

Make sure to test, review, and merge create the header block first! That branch has some overall styling that affects these changes.

⚠️ there will likely be a merge conflict once 9-create-the-header-block is merged into main from footer.css. The changes should be accepted from this branch.

Fix #10

Test URLs:

@tonyklapatch tonyklapatch linked an issue May 8, 2024 that may be closed by this pull request
Create the footer block #10
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 8, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 8, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@tonyklapatch
Copy link
Contributor Author

Fixed the merge conflict with footer.css.

codecodeio
codecodeio approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer looks good, just like the original.
Nice to add some site styles too.

bdeffleyfamous
bdeffleyfamous approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer looks good on desktop and mobile.

@bdeffleyfamous bdeffleyfamous merged commit bcfbe35 into main May 10, 2024
2 checks passed
@codecodeio codecodeio deleted the 10-create-the-footer-block branch June 7, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

@codecodeio codecodeio codecodeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the footer block
3 participants
@tonyklapatch @codecodeio @bdeffleyfamous