Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the header block #14

Merged
merged 7 commits into from
May 9, 2024
Merged

Create the header block #14

merged 7 commits into from
May 9, 2024

Conversation

tonyklapatch
Copy link
Contributor

@tonyklapatch tonyklapatch commented May 8, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #9. Adds base styling and styling for the header.

Test URLs:

@tonyklapatch tonyklapatch linked an issue May 8, 2024 that may be closed by this pull request
Create the header block #9
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 8, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 8, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 9-create-the-header-block May 8, 2024 16:54 Inactive
bdeffleyfamous
bdeffleyfamous approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Header now appears to be the same as it is on the word press site.

@aem-code-sync aem-code-sync bot temporarily deployed to 9-create-the-header-block May 8, 2024 19:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 9-create-the-header-block May 9, 2024 14:27 Inactive
codecodeio
codecodeio approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header looks good on mobile and erroneous lint checks are ignored.
Good to go.

best-cigars-guide/icons/best-cigars-selection-guide.png Outdated Show resolved Hide resolved
@codecodeio codecodeio merged commit 15fe265 into main May 9, 2024
2 checks passed
@codecodeio codecodeio deleted the 9-create-the-header-block branch June 7, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

@codecodeio codecodeio codecodeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the header block
3 participants
@tonyklapatch @codecodeio @bdeffleyfamous