Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php8 check+change dependencies:use psr/container package #1

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

mostafasy
Copy link

-add php8 to composer.json
-change dependencies:use psr/container package

Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but it would need to revive the CI to check against PHP 8 before going forward...

@mostafasy
Copy link
Author

mostafasy commented Feb 17, 2023

hi,so i have just already upgraded phpunit to last version and all tests were passed successfully.i tested with php 8.0 and php 8.1 and php 8.2, with Laminas Framwork and Mezzio Framwork and it work perfect,i think we are ready for new release.could you please do new Release,tag 1.0.0?

@mostafasy mostafasy requested a review from Jean85 April 24, 2023 21:36
@mostafasy
Copy link
Author

CI for php8.1, php 8.2 :
mostafasy#6
do you need somthing else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants