fix: account for there being no chunk with the same name as the chunk group #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack 4 introduced the concept of chunk groups.
I think there has been a false assumption in
webpack-flush-chunks
- that there is at least one chunk with the same name as the chunk group corresponding to the entry point or async chunk (provided via thebefore
andafter
parameters and thechunkNames
parameter respectively.In an app I was working with this was not the case. The flushing of chunks was failing with the error "... check usage of babel plugin" because
hasChunk
was checking for a chunk with the required name, when it should instead be checking for a chunk group with the required name.So the changes:
hasChunk
(nowhasChunkGroup
) to check thenamedChunkGroups
key in the stats object instead of theassetsByChunkName
key, fixing the bug I experienced.