Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Babel 7 #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chapati23
Copy link

Description

This PR updates the setup to babel 7 (@^7.0.0-beta.40, to be precise). The one thing I noticed is that on the "Admin" page there are two alerts for some reason. Couldn't get to the bottom of that unfortunately.

While updating to babel7 I noticed that the precommit hook was failing due to conflicting eslint and prettier rules. Also, some of the eslint plugins you installed as dependencies appeared to never have been in effect, actually (eslint-plugin-react e.g.). I've installed eslint-plugin-prettier along with eslint-config-prettier to leverage prettier for what it does best (formatting) and eslint what it does best (linting). I realize code formatting is a highly personal subject so let me know if any of the stylistic changes resulting from leveraging prettier more are making your inner code fashionista itchy. Happy to work around your preference. But since I moved to just letting prettier do the formatting work, I've never looked back :)

Done

  • Updated setup to babel 7
  • Updated all npm packages to latest version
  • Married prettier and eslint so they don't step on each other's toes anymore
  • Fixed a shit ton of eslint errors so that the precommit hook is actually useful again (some warnings remain, tho)

How to test

Dev Mode

  1. Check out this branch
  2. Run yarn
  3. Run yarn start
  4. Click around and see that everything still works

Prod Mode

  1. Check out this branch
  2. Run yarn
  3. Run yarn start:prod
  4. Click around and see that everything still works

@faceyspacey
Copy link
Owner

This one unfortunately is rougher, as I'm about to release Rudy, and there are changes to the demo/boilerplate based on that. I'm tempted to just take what you've done here and apply it there, as any time working on this puts Rudy back even farther. I pretty much agree with all your findings, and really appreciate this!

@chapati23
Copy link
Author

chapati23 commented Feb 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants