Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the setup to babel 7 (@^7.0.0-beta.40, to be precise). The one thing I noticed is that on the "Admin" page there are two alerts for some reason. Couldn't get to the bottom of that unfortunately.
While updating to babel7 I noticed that the
precommit
hook was failing due to conflicting eslint and prettier rules. Also, some of the eslint plugins you installed as dependencies appeared to never have been in effect, actually (eslint-plugin-react e.g.). I've installed eslint-plugin-prettier along with eslint-config-prettier to leverageprettier
for what it does best (formatting) andeslint
what it does best (linting). I realize code formatting is a highly personal subject so let me know if any of the stylistic changes resulting from leveragingprettier
more are making your inner code fashionista itchy. Happy to work around your preference. But since I moved to just letting prettier do the formatting work, I've never looked back :)Done
prettier
andeslint
so they don't step on each other's toes anymoreHow to test
Dev Mode
yarn
yarn start
Prod Mode
yarn
yarn start:prod