Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

created an abstract #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AlexeyAulov
Copy link

Description

There was an simplification issue that needed to be done for issue #77. Therefore, I made an abstract of the connections method called returnconnect in order for connections method to return only one line.

Fixes #77

Type of change

abstraction change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

Please describe the tests [UT/IT] that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.

For Backend
cd labgraph
python extensions/yaml_support/labgraph_monitor/examples/labgraph_monitor_example.py

For Frontend
cd extensions/prototypes/labgraph_monitor
yarn start

When the application starts
Go to labgraph application and press connect

Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Unit Test / Integration Test (UT/IT) execution results

  • Logs

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LabGraph Monitor API Improvement
2 participants