Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

fzchriha/network_socket #61

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fzchriha
Copy link
Contributor

@fzchriha fzchriha commented Feb 22, 2022

Description

Integrate Network Socket to LabGraph which will allow new devices to be automatically usable in LabGraph

Fixes #41

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the tests [UT/IT] that you ran to verify your changes and relevent result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Unit Test / Integration Test (UT/IT) execution results

  • Logs

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2022
@fzchriha fzchriha changed the title network socket initial commit fzchriha/network_socket Feb 22, 2022
@fzchriha
Copy link
Contributor Author

fzchriha commented Mar 4, 2022

@jfResearchEng Hi Jimmy, I had questions about creating the network socket protocol, I'm trying to look at ZMQ for similarities but I would appreciate guidance in terms of what are the functionalities needed for pysocket, and what kind of input (data structures) are being transferred

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Sockets Support in LabGraph
2 participants