Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Network Sockets Support in LabGraph #41

Open
jfResearchEng opened this issue Jan 14, 2022 · 4 comments · May be fixed by #61
Open

Network Sockets Support in LabGraph #41

jfResearchEng opened this issue Jan 14, 2022 · 4 comments · May be fixed by #61
Labels
good first issue Good for newcomers

Comments

@jfResearchEng
Copy link
Contributor

jfResearchEng commented Jan 14, 2022 •
edited
Loading

🚀 Feature

Sensor & Device integration is an important part to help accelerate researchers development. This integration on Network Sockets will allow new devices to be automatically usable in LabGraph. Network socket here refers to python socket module: https://docs.python.org/3/library/socket.html . A stretch goal is to also support Boost.Asio, https://www.boost.org/doc/libs/1_76_0/doc/html/boost_asio.html

Additional context

  1. Create relevant files using the example from https://github.com/facebookresearch/labgraph/tree/main/labgraph/zmq_node
  2. The code should be added at folder is https://github.com/facebookresearch/labgraph/tree/main/devices/protocols/
  3. Create setup.py and README.md, where example can be found at: https://github.com/facebookresearch/labgraph/tree/main/extensions/labgraph_viz
  4. Add github action support, reference: https://github.com/facebookresearch/labgraph/actions/workflows/main.yml
  5. Add proper license header, example.
@jfResearchEng jfResearchEng added the good first issue Good for newcomers label Jan 20, 2022
@fzchriha
Copy link
Contributor

Hey Jimmy I will start working on these issues

@jfResearchEng
Copy link
Contributor Author

Hey Jimmy I will start working on these issues

Sounds good!

@fzchriha
Copy link
Contributor

@jfResearchEng Hi Jimmy, in order to implement a py socket protocol, I'm relying on zmq_node as a reference. But I was wondering is there a way to test and visualize if the protocol is running effectively, besides just running tests and not getting an error?
Thank you!

@jfResearchEng
Copy link
Contributor Author

@jfResearchEng Hi Jimmy, in order to implement a py socket protocol, I'm relying on zmq_node as a reference. But I was wondering is there a way to test and visualize if the protocol is running effectively, besides just running tests and not getting an error? Thank you!

Non-Visualization tests are used as they can be added as automatic tests in continuous integration pipelines. There's no visualization test yet for protocol integration.

@fzchriha fzchriha linked a pull request Feb 22, 2022 that will close this issue
Draft
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fzchriha/network_socket fzchriha/labgraph
2 participants
@jfResearchEng @fzchriha