Skip to content

Commit

Permalink
Remove unused variables in fbpcf/mpc_std_lib/unified_data_process/ser…
Browse files Browse the repository at this point in the history
…ialization/RowStructureDefinition.h (#531)

Summary:
Pull Request resolved: #531

LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D53779568

fbshipit-source-id: 5e551ab8b86f1b1fd3027f1d3b123b11a6a1a46b
  • Loading branch information
r-barnes authored and facebook-github-bot committed Feb 18, 2024
1 parent a313608 commit 3e809b2
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ class RowStructureDefinition : public IRowStructureDefinition<schedulerId> {
columnDefinition : *columnDefinitions_.get()) {
const IColumnDefinition<schedulerId>* columnPointer =
columnDefinition.get();
auto columnType = columnDefinition->getColumnType();

if (columnDefinition->getColumnType() ==
IColumnDefinition<
Expand Down

0 comments on commit 3e809b2

Please sign in to comment.