-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Make FSDPv1 only perform cat() during last microbatch backward() within FlattenParamsWrapper #1178
Draft
chrisxcai
wants to merge
11
commits into
ngoyal_changes_for_pp_fp8
Choose a base branch
from
chriscai_ngoyal_changes_for_pp_fp8
base: ngoyal_changes_for_pp_fp8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Make FSDPv1 only perform cat() during last microbatch backward() within FlattenParamsWrapper #1178
chrisxcai
wants to merge
11
commits into
ngoyal_changes_for_pp_fp8
from
chriscai_ngoyal_changes_for_pp_fp8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Apr 19, 2024
GD06
reviewed
Apr 19, 2024
import functools | ||
|
||
def _post_accumulation_hook(new_param_stop_grad, new_param): | ||
# TODO: make it only call backward() only for last microbatch (within FSDP no_sync) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please try to split this into three logger.info
entries? I think the printing of new_param
failed as the new_param we used to build partial function was gone...
… last new_param_stop_grad is ready per, to reduce the call to SplitWithSizesBackward etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal from @GD06 : https://fburl.com/gdoc/byomncbg
trace before change (SplitWithSizesBackward triggered every microbatch per FSDP module):
https://fburl.com/perfdoctor/qdt32ibh
trace with applied change (SplitWithSizesBackward triggered only in last microbatch per FSDP module):
https://fburl.com/perfdoctor/mpjsoarn