Adding a test for parameter limits round trip. #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66413502 |
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 25, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
force-pushed
the
export-D66413502
branch
from
ce23cfe
to
dc733df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66413502 |
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 25, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 25, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 25, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
added 2 commits
November 25, 2024 22:33
Summary: I want to be able to test whether reading and writing works correctly, and being able to round trip like this will be helpful. In addition it might be useful to be able to write the entire model file out in an automated fashion and this is a first step. Reviewed By: jeongseok-meta Differential Revision: D66413501
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
force-pushed
the
export-D66413502
branch
from
dc733df
to
1d9f8a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66413502 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
jeongseok-meta
pushed a commit
that referenced
this pull request
Nov 26, 2024
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct. Reviewed By: jeongseok-meta Differential Revision: D66413502
|
This pull request has been merged in 983a234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I want to rewrite the limit parsing code, and a first step is adding a test to make sure I don't break anything. We have existing tests that validate loading models but we don't have precise checks that verify that every part of the limit loading is correct.
Reviewed By: jeongseok-meta
Differential Revision: D66413502