RepoSync with changes to commitMutation and updates to product code to remove explicit type annotations and use typed graphql tags for mutations.
#2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48543114 |
|
This pull request was exported from Phabricator. Differential Revision: D48543114 |
alunyov
added a commit
to alunyov/Recoil
that referenced
this pull request
Aug 22, 2023
… to remove explicit type annotations and use typed `graphql` tags for mutations. (facebookexperimental#2277) Summary: Pull Request resolved: facebookexperimental#2277 This is a RepoSync diff with changes to the product code: - Main change here is the updated `commitMutation` types that are using typed `graphql` tags. - Also this diff contains changes (mostly automated) to the product code that removes the explicit type annotations. See details on the codemod here: https://www.internalfb.com/intern/wiki/Relay-team/Flow_Integration/ - Additionally, this diff contain new $FlowFixMe in the places where new types uncovered issues with types. ---- Individual diffs for review: Product code changes: D48563977 FlowFixMe: D48563978 Reviewed By: captbaritone Differential Revision: D48543114 fbshipit-source-id: 6841d1f075642ca3b2c314e24f8613238f950b83
alunyov
force-pushed
the
export-D48543114
branch
from
f795706
to
03cd86d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48543114 |
alunyov
added a commit
to alunyov/Recoil
that referenced
this pull request
Aug 23, 2023
… to remove explicit type annotations and use typed `graphql` tags for mutations. (facebookexperimental#2277) Summary: Pull Request resolved: facebookexperimental#2277 This is a RepoSync diff with changes to the product code: - Main change here is the updated `commitMutation` types that are using typed `graphql` tags. - Also this diff contains changes (mostly automated) to the product code that removes the explicit type annotations. See details on the codemod here: https://www.internalfb.com/intern/wiki/Relay-team/Flow_Integration/ - Additionally, this diff contain new $FlowFixMe in the places where new types uncovered issues with types. ---- Individual diffs for review: Product code changes: D48563977 FlowFixMe: D48563978 Reviewed By: captbaritone Differential Revision: D48543114 fbshipit-source-id: 7b34a622d00a55d2e721b81e837efe9db1281178
alunyov
force-pushed
the
export-D48543114
branch
from
03cd86d
to
8cfd4ae
Compare
… to remove explicit type annotations and use typed `graphql` tags for mutations. (facebookexperimental#2277) Summary: Pull Request resolved: facebookexperimental#2277 This is a RepoSync diff with changes to the product code: - Main change here is the updated `commitMutation` types that are using typed `graphql` tags. - Also this diff contains changes (mostly automated) to the product code that removes the explicit type annotations. See details on the codemod here: https://www.internalfb.com/intern/wiki/Relay-team/Flow_Integration/ - Additionally, this diff contain new $FlowFixMe in the places where new types uncovered issues with types. ---- Individual diffs for review: Product code changes: D48563977 FlowFixMe: D48563978 Reviewed By: captbaritone Differential Revision: D48543114 fbshipit-source-id: 73efd4a93975b4da97e2c5eb673a4fe896f3ab0c
|
This pull request was exported from Phabricator. Differential Revision: D48543114 |
alunyov
force-pushed
the
export-D48543114
branch
from
8cfd4ae
to
f400265
Compare
facebook-github-bot
merged commit 0c62c96
into
facebookexperimental:main
3 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a RepoSync diff with changes to the product code:
commitMutationtypes that are using typedgraphqltags.Individual diffs for review:
Product code changes: D48563977
FlowFixMe: D48563978
Reviewed By: captbaritone
Differential Revision: D48543114