This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
Refs #185, remove trailing comma for .mention-bot file before JSON parse #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before JSON parse
|
@jeffreyleeon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @saiqulhaq, @vjeux and @jgardella to be potential reviewers. |
This was referenced Nov 24, 2016
|
Hey @jeffreyleeon, sorry it took me a few days to review this. Unfortunately, the JSON specification disallows trailing commas. I would rather not start supporting invalid JSON there. However, it would be awesome to report back on the pull request that the configuration was invalid so that it's easy to spot the error. Would you mind sending a pull request for that instead? Thanks! |
|
@vjeux Good idea! |
|
@vjeux That's a nice feature! I will try to give a pull request for this. Thanks! |
|
@jeffreyleeon thanks! I will review it more quickly this time! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #185