Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement core::error::Error for all error types #341

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

PhilippGackstatter
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter commented Nov 18, 2024

Implements core::error::Error for all error types in a non-breaking way, which is why this targets main.

The motivation is to be able to wrap these errors in Box<dyn Error> and use them as source errors which requires the trait to be implemented.

Also fixes a clippy lint introduced in a recent rust nightly version replacing string.as_bytes().len() with string.len().

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@irakliyk irakliyk merged commit 0fe84be into facebook:main Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants