Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Documentation of the default prover/verifier example causes issue in rust analyser #325

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

radicleart
Copy link
Contributor

PR fixes a minor issue in the documentation of the default prover/verifier example - note the cargo build is independent of this problem.

The prover example causes rust analyser (vs code) to flag an error - requiring a ref to be added here E::from(42u32) - adding the ref causes the analyser to flag another error asking for the ref to be removed.

let current_state = &frame.current()[0];
let next_state = current_state.exp(3u32.into()) + E::from(42u32); 

Removing the ref in the first line solves the problem.

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for fixing it!

@irakliyk irakliyk merged commit da7f84a into facebook:main Sep 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants