Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize auxiliary trace building #271

Merged
merged 105 commits into from
May 6, 2024
Merged

Generalize auxiliary trace building #271

merged 105 commits into from
May 6, 2024

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Apr 19, 2024 •
edited
Loading

Closes #257

plafer added 27 commits April 18, 2024 12:54
@plafer
AuxTraceBuilder
583bfc1
@plafer
AuxTraceElements associated types
eedada2
@plafer
fix generate_proof()
adfc935
@plafer
fix all but tests
ef13e12
@plafer
Air: Make AuxRandElements generic over E
ea0e7a6
@plafer
Prover: make AuxRandElements generic over E
7a06cb3
@plafer
AuxTraceBuilder: make AuxRandElements generic over E
2519fa9
@plafer
prover: fix Lagrange benchmark
1a06b9d
@plafer
fix verifier
a134514
@plafer
fix comment
40751af
@plafer
prover: add prove_with_aux_trace()
ce25415
@plafer
prover: add prove_with_aux_trace()
60328de
@plafer
verifier: remove dead code
be9b0c3
@plafer
fix prover benches
13ad3b6
@plafer
Introduce DefaultAuxTraceVerifier
59bfc15
@plafer
fix test_complex_lagrange_kernel_air
fe2dfe9
@plafer
prove: remove <E>
dd5a135
@plafer
fmt
7e3e7ff
@plafer
verifier: split verify() functions
10c17df
@plafer
fix fib_small example
0f32099
@plafer
fix examples
e22c3dd
@plafer
winterfell exports
5495886
@plafer
fix rescue_raps example
58a37ef
@plafer
fix verify_with_aux_trace
63063f3
@plafer
fix rescue_raps
d041dfa
@plafer
Remove AuxTraceRandElements
64cec4e
@plafer
Remove Trace::build_aux_segment()
1ec3020
@plafer plafer changed the base branch from main to next April 19, 2024 19:26
@plafer plafer requested a review from irakliyk May 6, 2024 18:17
irakliyk
irakliyk approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few comments inline. Most of them are minor nits and the one about replacing GkrVerifier with a function can be addressed in a subsequent PR.

air/src/air/aux.rs Outdated Show resolved Hide resolved
air/src/air/mod.rs Outdated Show resolved Hide resolved
air/src/air/mod.rs Show resolved Hide resolved
air/src/air/mod.rs Show resolved Hide resolved
prover/src/trace/mod.rs Show resolved Hide resolved
verifier/src/errors.rs Outdated Show resolved Hide resolved
@plafer plafer mentioned this pull request May 6, 2024
Open
irakliyk
irakliyk approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@irakliyk irakliyk merged commit 0e53f2f into facebook:next May 6, 2024
7 checks passed
@plafer plafer deleted the plafer-generalize-aux-trace-building branch May 7, 2024 10:39
irakliyk pushed a commit that referenced this pull request May 9, 2024
@plafer @irakliyk
Generalize auxiliary trace building (#271)
1f26379
@irakliyk irakliyk mentioned this pull request May 9, 2024
Closed
irakliyk pushed a commit that referenced this pull request May 9, 2024
@plafer @irakliyk
Generalize auxiliary trace building (#271)
bfa737e
@plafer plafer mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al-Kindi-0 Al-Kindi-0 Al-Kindi-0 left review comments

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize auxiliary trace building logic
4 participants
@plafer @irakliyk @Al-Kindi-0 @facebook-github-bot