No need to change visibility twice

Reviewed By: thezhangwei Differential Revision: D49213736 fbshipit-source-id: 1659689172ecdb2843588acec3dc2453ffc17cf2
facebook · Sep 15, 2023 · 55fbaf1 · 55fbaf1
1 parent f643043
commit 55fbaf1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/libredex/DexUtil.cpp b/libredex/DexUtil.cpp
@@ -441,7 +441,6 @@ bool relocate_method_if_no_changes(DexMethod* method, DexType* to_type) {
   set_public(method);
   change_visibility(method, to_type);
   relocate_method(method, to_type);
-  change_visibility(method);
 
   return true;
 }

diff --git a/service/class-splitting/ClassSplitting.cpp b/service/class-splitting/ClassSplitting.cpp
@@ -526,7 +526,6 @@ void ClassSplitter::cleanup(const Scope& final_scope) {
     }
     change_visibility(method, target_cls->get_type());
     relocate_method(method, target_cls->get_type());
-    change_visibility(method);
   }
   TRACE(CS, 2, "[class splitting] Made {%zu} methods static.",
         methods_to_staticize.size());